HomePhabricator

Fix race condition inside `git diff-files`

Description

Fix race condition inside git diff-files

Summary:
There's some sort of race inside git here, where the git diff-files command exits with different results some of the time when run in parallel with git ls-files or git diff (running either command was sufficient to trigger the race).

Run it separately to avoid the race.

I poked around the git source a little bit but quickly lost interest given that the issue seems fixed and this workaround is essentially reasonable.

Test Plan: Ran test 20x in a row without failures.

Reviewers: hach-que

Reviewed By: hach-que

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D9616

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Jun 18 2014, 12:33 PM
Reviewer
hach-que
Differential Revision
D9616: Fix race condition inside `git diff-files`
Parents
rARC9257f1bc8585: Add a newline to the output of `arc help --full`.
Branches
Unknown
Tags
Unknown

Event Timeline