Page MenuHomePhabricator

Fix race condition inside `git diff-files`
ClosedPublic

Authored by epriestley on Jun 18 2014, 12:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
May 19 2025, 7:06 AM
Unknown Object (File)
May 7 2025, 10:57 AM
Unknown Object (File)
Apr 28 2025, 2:29 AM
Unknown Object (File)
Apr 28 2025, 2:29 AM
Unknown Object (File)
Apr 28 2025, 2:09 AM
Unknown Object (File)
Apr 22 2025, 3:31 AM
Unknown Object (File)
Apr 17 2025, 11:47 AM
Unknown Object (File)
Apr 10 2025, 3:33 PM
Subscribers

Details

Summary

There's some sort of race inside git here, where the git diff-files command exits with different results some of the time when run in parallel with git ls-files or git diff (running either command was sufficient to trigger the race).

Run it separately to avoid the race.

I poked around the git source a little bit but quickly lost interest given that the issue seems fixed and this workaround is essentially reasonable.

Test Plan

Ran test 20x in a row without failures.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix race condition inside `git diff-files`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: hach-que.
hach-que edited edge metadata.

Ran it 5x in a row, no problemo.

This revision is now accepted and ready to land.Jun 18 2014, 6:45 AM
epriestley updated this revision to Diff 23066.

Closed by commit rARCdd1f93d77b5f (authored by @epriestley).