Page MenuHomePhabricator

Fix race condition inside `git diff-files`
ClosedPublic

Authored by epriestley on Jun 18 2014, 12:11 AM.
Tags
None
Referenced Files
F14035078: D9616.diff
Sun, Nov 10, 4:01 AM
F14018727: D9616.diff
Tue, Nov 5, 6:50 PM
F14016189: D9616.diff
Mon, Nov 4, 7:03 AM
F13991399: D9616.id23066.diff
Tue, Oct 22, 10:36 AM
F13983973: D9616.diff
Sun, Oct 20, 10:02 AM
F13968311: D9616.id23052.diff
Wed, Oct 16, 8:02 PM
Unknown Object (File)
Sep 18 2024, 7:03 AM
Unknown Object (File)
Sep 5 2024, 3:16 PM
Subscribers

Details

Summary

There's some sort of race inside git here, where the git diff-files command exits with different results some of the time when run in parallel with git ls-files or git diff (running either command was sufficient to trigger the race).

Run it separately to avoid the race.

I poked around the git source a little bit but quickly lost interest given that the issue seems fixed and this workaround is essentially reasonable.

Test Plan

Ran test 20x in a row without failures.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix race condition inside `git diff-files`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: hach-que.
hach-que edited edge metadata.

Ran it 5x in a row, no problemo.

This revision is now accepted and ready to land.Jun 18 2014, 6:45 AM
epriestley updated this revision to Diff 23066.

Closed by commit rARCdd1f93d77b5f (authored by @epriestley).