HomePhabricator

Catch more product names in "pht()", and replace newly matched Arcanist product…

Description

Catch more product names in "pht()", and replace newly matched Arcanist product names

Summary:
Ref T13658. The lint rule called "getStringLiteralValue()", which produces string literals for fewer nodes than "evalStatic()".

Switch to "evalStatic()", then fix new warnings.

Test Plan:
This test plan is non-exhaustive.

  • Ran "arc lint --everything --output summary" to generate new warnings.

Maniphest Tasks: T13658

Differential Revision: https://secure.phabricator.com/D21776

Details