HomePhabricator

Improve strictness around `setLine()` types in ArcanistLintMessage

Description

Improve strictness around setLine() types in ArcanistLintMessage

Summary: Fixes T8921. Harbormaster is strict about types it accepts, but ArcanistLintMessage is more liberal. Push the strictness barrier down to the linter level, while maintaining reasonable flexibility in the API.

Test Plan: arc unit --everything

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8921

Differential Revision: https://secure.phabricator.com/D13695

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Jul 23 2015, 8:19 PM
Reviewer
chad
Differential Revision
D13695: Improve strictness around `setLine()` types in ArcanistLintMessage
Parents
rARC5e4f9a2bf9d2: Fix checkstyle severities
Branches
Unknown
Tags
Unknown
Tasks
T8921: arc diff failing due to "invalid type" error