Page MenuHomePhabricator

Improve strictness around `setLine()` types in ArcanistLintMessage
ClosedPublic

Authored by epriestley on Jul 23 2015, 8:17 PM.
Tags
None
Referenced Files
F14399338: D13695.id33102.diff
Sun, Dec 22, 4:40 PM
Unknown Object (File)
Sun, Dec 22, 2:06 AM
Unknown Object (File)
Sat, Dec 21, 3:20 PM
Unknown Object (File)
Mon, Dec 16, 1:53 PM
Unknown Object (File)
Tue, Dec 10, 1:54 PM
Unknown Object (File)
Thu, Dec 5, 1:05 PM
Unknown Object (File)
Tue, Dec 3, 12:08 AM
Unknown Object (File)
Sat, Nov 30, 1:46 AM
Subscribers

Details

Summary

Fixes T8921. Harbormaster is strict about types it accepts, but ArcanistLintMessage is more liberal. Push the strictness barrier down to the linter level, while maintaining reasonable flexibility in the API.

Test Plan

arc unit --everything

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve strictness around `setLine()` types in ArcanistLintMessage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2015, 8:19 PM
This revision was automatically updated to reflect the committed changes.