Diffusion Arcanist 7570dd0da119

Improve "PhutilJSON" handling of PHP-object JSON values
7570dd0da119
Actions

Description

Improve "PhutilJSON" handling of PHP-object JSON values

Summary:
Ref T13635. PHP native JSON functions sometimes represent JSON objects as PHP "stdClass" objects.

Accept this representation and emit it correctly in "PhutilJSON".

Test Plan: Added a test, made it pass.

Maniphest Tasks: T13635

Differential Revision: https://secure.phabricator.com/D21604

Details

Provenance

epriestley	Authored on Mar 11 2021, 7:20 PM
epriestley	Pushed on Mar 11 2021, 8:43 PM

Differential Revision

D21604: Improve "PhutilJSON" handling of PHP-object JSON values

Parents

rARC2d6452acb5f1: In Arcanist, when trying to write to a file configuration source, create…

Branches

Unknown

Tags

Unknown

Tasks

T13635: JSON DocumentEngine may confuse "{}" and "[]"

Build Status

Buildable 25240
Build 34835: Run Core Tests

Event Timeline

epriestley committed rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values (authored by epriestley).Mar 11 2021, 8:43 PM

epriestley added a task: T13635: JSON DocumentEngine may confuse "{}" and "[]".

epriestley added an edge: D21604: Improve "PhutilJSON" handling of PHP-object JSON values.

Harbormaster completed building B25240: rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values.Mar 11 2021, 8:43 PM

Changes (2)

Path

Size

src/

parser/

PhutilJSON.php

__tests__/

PhutilJSONTestCase.php

rARC7570dd0da119

View Options

src/parser/PhutilJSON.php