Page MenuHomePhabricator
Differential D21604

Improve "PhutilJSON" handling of PHP-object JSON values
ClosedPublic
Actions

Authored by epriestley on Mar 11 2021, 7:22 PM.
Tags
None
Referenced Files
F18268959: D21604.diff
Fri, Aug 22, 2:21 PM
F18234528: D21604.diff
Wed, Aug 20, 6:10 PM
F18188598: D21604.id51433.diff
Sat, Aug 16, 9:22 PM
F18109918: D21604.id.diff
Mon, Aug 11, 3:25 PM
F18104456: D21604.diff
Sun, Aug 10, 12:27 PM
F17944007: D21604.id51433.diff
Thu, Jul 31, 9:09 AM
F17944006: D21604.id51431.diff
Thu, Jul 31, 9:09 AM
F17943685: D21604.id.diff
Thu, Jul 31, 8:37 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13635: JSON DocumentEngine may confuse "{}" and "[]"
Commits
rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values
Summary

Ref T13635. PHP native JSON functions sometimes represent JSON objects as PHP "stdClass" objects.

Accept this representation and emit it correctly in "PhutilJSON".

Test Plan

Added a test, made it pass.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 11 2021, 7:22 PM
Harbormaster completed remote builds in B25238: Diff 51431.Mar 11 2021, 7:22 PM
epriestley requested review of this revision.Mar 11 2021, 7:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:43 PM
Closed by commit rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values.

Revision Contents
Changeset List

PathSize
src/
parser/
8 lines
__tests__/
29 lines

Diff 51433

View Options

src/parser/PhutilJSON.php

Loading...
View Options

src/parser/__tests__/PhutilJSONTestCase.php

Loading...
Phabricator · Built by Phacility