Page MenuHomePhabricator
Differential D14514

Write a linter rule for `$this` reassignment
ClosedPublic
Actions

Authored by joshuaspence on Nov 18 2015, 10:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 2:54 AM
Unknown Object (File)
Fri, Mar 29, 1:35 PM
Unknown Object (File)
Mar 23 2024, 11:29 PM
Unknown Object (File)
Mar 7 2024, 4:55 PM
Unknown Object (File)
Mar 6 2024, 5:22 AM
Unknown Object (File)
Mar 6 2024, 5:22 AM
Unknown Object (File)
Mar 6 2024, 4:45 AM
Unknown Object (File)
Jan 5 2024, 11:32 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC581829a99ee8: Write a linter rule for `$this` reassignment
Summary

Re-assigning $this is an invalid PHP construct, see https://3v4l.org/TauX9.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35111.Nov 18 2015, 10:42 PM
joshuaspence retitled this revision from to Write a linter rule for `$this` reassignment.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 18 2015, 10:42 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 18 2015, 11:04 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2015, 11:04 PM
joshuaspence updated this revision to Diff 35116.Nov 19 2015, 12:26 AM
joshuaspence edited edge metadata.

Minor fix

Closed by commit rARC581829a99ee8: Write a linter rule for `$this` reassignment (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 19 2015, 7:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
lint/
linter/
xhpast/
rules/
39 lines
__tests__/
10 lines
this-reassignment/
8 lines
4 lines

Diff 35130

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistThisReassignmentXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistThisReassignmentXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/this-reassignment/class.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/this-reassignment/this.lint-test

Loading...
Phabricator · Built by Phacility