Page MenuHomePhabricator

Fix a fatal error in `ArcanistXHPASTLinter`
ClosedPublic

Authored by joshuaspence on Sep 24 2014, 9:30 PM.
Tags
None
Referenced Files
F14027641: D10551.diff
Fri, Nov 8, 8:21 AM
F14022817: D10551.diff
Wed, Nov 6, 7:59 PM
F13999792: D10551.diff
Thu, Oct 24, 5:14 PM
F13984971: D10551.id25351.diff
Sun, Oct 20, 5:15 PM
Unknown Object (File)
Oct 7 2024, 11:41 AM
Unknown Object (File)
Oct 2 2024, 7:43 AM
Unknown Object (File)
Sep 12 2024, 3:12 PM
Unknown Object (File)
Sep 12 2024, 3:11 PM
Subscribers

Details

Summary

I had assumed that we would always be interested in n_STATEMENT_LIST, which is fine for if (...) { some_statements(); } but not for if (...) one_statement();.

Test Plan

Added a test case.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Fix a fatal error in `ArcanistXHPASTLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 24 2014, 9:32 PM
This revision was automatically updated to reflect the committed changes.