HomePhabricator

Improve 'arc get-config', 'arc set-config' and show more config info with…

Description

Improve 'arc get-config', 'arc set-config' and show more config info with --trace

Summary:
Fixes T4952. Several issues:

  • You review configuration values with arc set-config --show. This makes no sense and never has, I think it just predated arc get-config or was easier or something.
    • Instead, review values with arc get-config and review details with arc get-config --verbose.
  • Show better and more detailed information about all config sources.
  • Establish and show default values from a new "default" source.
  • With --trace include more information about attempts to read configuration files.

Test Plan:
Ran arc get-config --trace --verbose in various working directories and received sensible-looking output.

Screen_Shot_2014-05-17_at_5.49.45_PM.png (310×590 px, 33 KB)

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4952

Differential Revision: https://secure.phabricator.com/D9172

Event Timeline

We're noticed after our last update of Arcanist/Phabricator that Arcanist is modifying the Mercurial commit message of the tip - I thought maybe it was a new feature but realized that it was an existing feature that had been off by default. I suspect this commit changed that default (not sure though, I don't know the codebase well). If it was intentional the documentation doesn't reflect that.

/src/configuration/ArcanistSettings.php
118

Is it possible that this changed the default for Mercurial? I've been investigating some problems at our work site and I think this might be the root cause

/src/configuration/ArcanistSettings.php
118

Ah, I think you're correct.

This should be fixed in HEAD. Normally, you can use arc upgrade to update.