Page MenuHomePhabricator

Improve 'arc get-config', 'arc set-config' and show more config info with --trace
ClosedPublic

Authored by epriestley on May 18 2014, 12:57 AM.
Tags
None
Referenced Files
F14835539: D9172.id21895.diff
Thu, Jan 30, 9:33 PM
Unknown Object (File)
Sun, Jan 26, 4:17 PM
Unknown Object (File)
Sun, Jan 26, 4:16 PM
Unknown Object (File)
Sun, Jan 26, 4:16 PM
Unknown Object (File)
Sun, Jan 26, 4:05 PM
Unknown Object (File)
Mon, Jan 20, 6:45 PM
Unknown Object (File)
Sat, Jan 18, 3:21 PM
Unknown Object (File)
Fri, Jan 17, 6:39 AM
Subscribers

Details

Summary

Fixes T4952. Several issues:

  • You review configuration values with arc set-config --show. This makes no sense and never has, I think it just predated arc get-config or was easier or something.
    • Instead, review values with arc get-config and review details with arc get-config --verbose.
  • Show better and more detailed information about all config sources.
  • Establish and show default values from a new "default" source.
  • With --trace include more information about attempts to read configuration files.
Test Plan

Ran arc get-config --trace --verbose in various working directories and received sensible-looking output.

Screen_Shot_2014-05-17_at_5.49.45_PM.png (310×590 px, 33 KB)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Improve 'arc get-config', 'arc set-config' and show more config info with --trace.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:20 PM
epriestley updated this revision to Diff 21895.

Closed by commit rARC104219dd62ee (authored by @epriestley).