HomePhabricator

Add an XHPAST lint rule for empty block statements

Description

Add an XHPAST lint rule for empty block statements

Summary: Adds an XHPAST linter rule for empty block statements. Basically, if a block statement is empty then it is much neater if the opening ({) and closing (}) braces are adjacent. Maybe this is just my own personal preference, in which case we could reduce the default severity to ArcanistLintSeverity::SEVERITY_DISABLED.

Test Plan: Wrote unit tests. I had to modify a bunch of existing unit tests accordingly.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10434

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Sep 9 2014, 2:12 PM
Reviewer
Blessed Reviewers
Differential Revision
D10434: Add an XHPAST lint rule for empty block statements
Parents
rARCd4f9526e7626: Add some missing function parameter typehints
Branches
Unknown
Tags
Unknown

Event Timeline