Add an XHPAST lint rule for empty block statements
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2014, 6:58 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC04de9311511d: Add an XHPAST lint rule for empty block statements

Summary

Adds an XHPAST linter rule for empty block statements. Basically, if a block statement is empty then it is much neater if the opening ({) and closing (}) braces are adjacent. Maybe this is just my own personal preference, in which case we could reduce the default severity to ArcanistLintSeverity::SEVERITY_DISABLED.

Test Plan

Wrote unit tests. I had to modify a bunch of existing unit tests accordingly.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 25095.Sep 6 2014, 6:58 AM

joshuaspence retitled this revision from to Add an XHPAST lint rule for empty block statements.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2014, 6:58 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2452: Diff 25095.Sep 6 2014, 6:59 AM

joshuaspence updated this object.Sep 7 2014, 7:28 AM

joshuaspence edited edge metadata.

joshuaspence updated this object.Sep 7 2014, 7:34 AM

In normal code I think empty bodies should usually have an explanatory comment (e.g., why the exception is OK to drop on the ground in an empty catch block, or what a loop-acting-through-side-effects is doing) although I wouldn't want to force that. This rule seems OK for blocks without a comment.