Page MenuHomePhabricator

meitros (Mihir Kedia)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2011, 6:28 AM (713 w, 2 d)
Availability
Available

Recent Activity

Apr 9 2016

20after4 awarded D14104: arc revise: more collaborative code reviews (NOT FOR UPSTREAM) a Like token.
Apr 9 2016, 5:00 PM

Mar 22 2016

meitros added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

as the author of D14104, the advisory update proposal here would make me happy. Its basically taking the class of comments that are suggesting specific fixes or additions and making it more lightweight. One minor ui problem to solve would be supporting pure inserts or deletes.

Mar 22 2016, 4:15 PM · Differential

Nov 7 2015

meitros added a comment to T9729: Query differential messages via Conduit API.

@mjlyons, if its a one-time thing you could just pull the data directly from the db. If its ongoing, IMO its really easy to write a custom, one-off api method

Nov 7 2015, 6:20 AM · Unknown Object (Project)

Nov 3 2015

meitros awarded D14391: Replace Roboto Slab with Aleo for PHUIDocumentView a Doubloon token.
Nov 3 2015, 5:27 AM

Sep 17 2015

meitros updated subscribers of T8588: One instance has a severe, global performance issue.

just a heads up that I'm not actively working on this any more (have to finish other things before my contract ends.)
Last time this was discussed, @vishal proposed tweaking our current APC settings.

Sep 17 2015, 9:06 PM · Unknown Object (Project)

Sep 16 2015

meitros planned changes to D14104: arc revise: more collaborative code reviews (NOT FOR UPSTREAM).
Sep 16 2015, 3:19 AM

Sep 14 2015

meitros added a comment to D14104: arc revise: more collaborative code reviews (NOT FOR UPSTREAM).

Can you prevent these with lint?

Sep 14 2015, 4:47 PM
meitros added a comment to D14104: arc revise: more collaborative code reviews (NOT FOR UPSTREAM).

Possible tl;dr: I think we have different perspectives on when this will be used - you added a git add -p proposal that makes this more heavyweight and substantiative (but also believe that this is just not the right approach), I want to make more lightweight diffs more convenient (lightweight diffs are probably a plurality, if not majority.)

Sep 14 2015, 2:07 AM

Sep 13 2015

meitros retitled D14104: arc revise: more collaborative code reviews (NOT FOR UPSTREAM) from to arc revise: more collaborative code reviews (NOT FOR UPSTREAM).
Sep 13 2015, 8:11 PM
meitros edited P1854 diff of arc revise.
Sep 13 2015, 8:08 PM

Sep 10 2015

meitros updated the diff for D14064: Add dialog to purge opcode/data caches.

fixes and minor changes. also retested

Sep 10 2015, 9:18 PM
meitros added a comment to D14064: Add dialog to purge opcode/data caches.

I forgot to retest, so if you accept hold off on pulling until I do

Sep 10 2015, 5:01 PM
meitros updated the diff for D14064: Add dialog to purge opcode/data caches.

fixes. Didn't think of a less clunky name for clearCacheCallback

Sep 10 2015, 1:22 PM
meitros added a comment to D14064: Add dialog to purge opcode/data caches.

Screen Shot 2015-09-09 at 8.30.55 PM.png (576×1 px, 66 KB)

Sep 10 2015, 3:31 AM
meitros updated the diff for D14064: Add dialog to purge opcode/data caches.

add current web frontend caveat

Sep 10 2015, 3:26 AM
meitros updated the diff for D14064: Add dialog to purge opcode/data caches.

epriestley

Sep 10 2015, 3:21 AM
meitros retitled D14064: Add dialog to purge opcode/data caches from RFC: Add controller to purge apc to Add dialog to purge opcode/data caches.
Sep 10 2015, 3:19 AM
meitros added a comment to T9380: lint/unit failures cause confusing error message.

Renaming to arc lint + arc unit sounds good and clearer to me.

Sep 10 2015, 2:13 AM · Arcanist, Harbormaster, Unknown Object (Project)
meitros created T9380: lint/unit failures cause confusing error message.
Sep 10 2015, 1:20 AM · Arcanist, Harbormaster, Unknown Object (Project)

Sep 7 2015

meitros added a comment to T8588: One instance has a severe, global performance issue.

/changes/inline is new and has only existed for <1 week, btw

Sep 7 2015, 3:16 PM · Unknown Object (Project)
meitros added a comment to T8588: One instance has a severe, global performance issue.

New startup tab for creating an inline comment:

Screen Shot 2015-09-07 at 7.37.27 AM.png (824×2 px, 150 KB)
. The time spend loading libraries varied from 50k-75k

Sep 7 2015, 2:42 PM · Unknown Object (Project)

Sep 5 2015

meitros planned changes to D14064: Add dialog to purge opcode/data caches.

I'll do it, but not for a few days

Sep 5 2015, 7:21 PM
meitros retitled D14064: Add dialog to purge opcode/data caches from to RFC: Add controller to purge apc.
Sep 5 2015, 7:02 PM

Sep 4 2015

meitros awarded D14061: Correct a bad Herald migration a Yellow Medal token.
Sep 4 2015, 10:01 PM

Sep 1 2015

meitros abandoned D14035: update libphutil (see merge commit).

wrong phabricator :(

Sep 1 2015, 8:52 PM
meitros retitled D14035: update libphutil (see merge commit) from to update libphutil (see merge commit).
Sep 1 2015, 8:49 PM
meitros added a comment to D13860: Fix failing JSHint linter test.

this change causes jshint 2.7.0 to break. Your change anticipates jshint erroring on the ~~~~~ line, but this is the only test in this directory that does that. The answer to the breakage I'm seeing might just be "use the latest version of jshint", but I just wanted to double check the inconsistency and the use of an error for a line that's not part of the code.

Sep 1 2015, 6:08 PM
meitros added a comment to T9289: Unable to build XHPAST.

https://secure.phabricator.com/D14031

Sep 1 2015, 3:55 PM · XHPAST
meitros added a comment to D14031: Fix XHPAST Makefile on OS X.

don't forget the Contributor badge :P

Sep 1 2015, 3:47 PM
meitros retitled D14031: Fix XHPAST Makefile on OS X from to Fix XHPAST Makefile on OS X.
Sep 1 2015, 3:39 PM
meitros added a comment to T9289: Unable to build XHPAST.

Also unable to build XHPAST, but for a different reason.

Sep 1 2015, 3:36 PM · XHPAST

Aug 7 2015

meitros created T9106: mailing list users should have their emails displayed on the user page.
Aug 7 2015, 5:41 PM · People

Jul 25 2015

meitros updated subscribers of T8956: Getting PHID data in one api call.
Jul 25 2015, 2:03 AM · Conduit
meitros created T8956: Getting PHID data in one api call.
Jul 25 2015, 2:03 AM · Conduit

Jul 7 2015

meitros added a comment to D13559: Fix bin/lipsum.

Having trouble landing this (git push 403s). I double checked the contributor guide, added my ssh-key to my account, tried setting my remote url to both the https and ssh remote url on the rPhabricator diffusion page:

Jul 7 2015, 5:56 AM

Jul 6 2015

meitros retitled D13559: Fix bin/lipsum from to Fix bin/lipsum.
Jul 6 2015, 7:04 AM