Page MenuHomePhabricator

Correct a bad Herald migration
ClosedPublic

Authored by epriestley on Sep 4 2015, 9:58 PM.
Tags
None
Referenced Files
F18085170: D14061.id.diff
Tue, Aug 5, 7:02 PM
F18051479: D14061.id.diff
Sun, Aug 3, 11:25 PM
F18043367: D14061.id.diff
Sun, Aug 3, 5:47 AM
F18000069: D14061.diff
Sat, Aug 2, 7:07 AM
F17951065: D14061.diff
Fri, Aug 1, 12:58 AM
F17890047: D14061.id33997.diff
Tue, Jul 29, 3:09 AM
F17806138: D14061.id.diff
Fri, Jul 25, 1:28 PM
F17768913: D14061.diff
Wed, Jul 23, 7:49 AM
Subscribers
None
Tokens
"Yellow Medal" token, awarded by meitros.

Details

Summary

One of the migrations in rPa335004a91 (20150730.herald.5.sql) incorrectly swapped "add" and "add blocking" Differential Herald rules.

Swap any rules last modified before this patch was applied back. This is the best we can do without possibly overwriting more recent, intentional data. I'll issue some guidance on this in the changelog.

Test Plan
  • Made a rule, ran patch, no change.
  • Changed rule modified time to a few months ago, ran patch, saw swap from non-blocking to blocking.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable