Infrastructure and Software Engineer for BitBoxUSA
User Details
User Details
- User Since
- Jul 19 2018, 11:24 PM (340 w, 5 d)
- Availability
- Available
Jul 23 2018
Jul 23 2018
Fix file encoding migration
kaendfinger2 added a comment to D19534: Fix Lipsum generators for Differential Revisions and Pastes.
@epriestley Thank you very much. I've landed this patch. I've got a few more things I've discovered I'll be submitting for review as well. I'll make sure to use two spaces instead of four (I think this is because PhpStorm sets a 'continuation indent' to four and not two)
kaendfinger2 committed rP6b6e1f0ba890: Fix Lipsum generators for Differential Revisions and Pastes (authored by kaendfinger2).
Fix Lipsum generators for Differential Revisions and Pastes
Jul 22 2018
Jul 22 2018
kaendfinger2 requested review of D19534: Fix Lipsum generators for Differential Revisions and Pastes.
kaendfinger2 added a comment to D19533: Fix file encoding migration.
Note that the lints and unit tests do pass on my end. I used the "Create Diff" action to do this instead of arc diff (which was silly of me)
kaendfinger2 edited the content of Organizations Using Phabricator.
kaendfinger2 requested review of D19533: Fix file encoding migration.