Page MenuHomePhabricator
Differential D19534

Fix Lipsum generators for Differential Revisions and Pastes
ClosedPublic
Actions

Authored by kaendfinger2 on Jul 22 2018, 5:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 11:12 AM
Unknown Object (File)
Wed, Jan 8, 2:35 PM
Unknown Object (File)
Sat, Jan 4, 11:07 PM
Unknown Object (File)
Tue, Dec 31, 3:23 PM
Unknown Object (File)
Sat, Dec 28, 2:52 PM
Unknown Object (File)
Sat, Dec 28, 2:50 PM
Unknown Object (File)
Sat, Dec 28, 12:47 PM
Unknown Object (File)
Thu, Dec 26, 5:51 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP6b6e1f0ba890: Fix Lipsum generators for Differential Revisions and Pastes
Summary

When generating test data to solve a bug I have encountered, I noticed Lipsum was not working correctly for Differential Revisions and Pastes.

It seemed like they weren't updated after some refactoring. This fixes that by updating them.

Test Plan

Run Lipsum for all objects, and note that it has much less failure.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kaendfinger2 created this revision.Jul 22 2018, 5:52 PM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 22 2018, 5:52 PM
Herald added a subscriber: epriestley. · View Herald Transcript
kaendfinger2 requested review of this revision.Jul 22 2018, 5:52 PM
Harbormaster completed remote builds in B20498: Diff 46700.Jul 22 2018, 5:52 PM
epriestley accepted this revision.Jul 23 2018, 7:53 PM

This looks like it has some 4-space indents. In this project, for consistency, prefer 2-space indents.

I added you to Community (granting you sweeping janitorial powers on this install) and Blessed Committers, allowing you to land this yourself. That project's description has some instructions for pushing. Yell if you run into trouble.

This revision is now accepted and ready to land.Jul 23 2018, 7:53 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJul 23 2018, 7:53 PM
Closed by commit rP6b6e1f0ba890: Fix Lipsum generators for Differential Revisions and Pastes (authored by kaendfinger2). · Explain WhyJul 23 2018, 8:05 PM
This revision was automatically updated to reflect the committed changes.
kaendfinger2 added a comment.Jul 23 2018, 8:07 PM

@epriestley Thank you very much. I've landed this patch. I've got a few more things I've discovered I'll be submitting for review as well. I'll make sure to use two spaces instead of four (I think this is because PhpStorm sets a 'continuation indent' to four and not two)

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
lipsum/
10 lines
paste/
lipsum/
48 lines

Diff 46705

View Options

src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php

Loading...
View Options

src/applications/paste/lipsum/PhabricatorPasteTestDataGenerator.php

Loading...
Phabricator · Built by Phacility