When generating test data to solve a bug I have encountered, I noticed Lipsum was not working correctly for Differential Revisions and Pastes.
It seemed like they weren't updated after some refactoring. This fixes that by updating them.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rP6b6e1f0ba890: Fix Lipsum generators for Differential Revisions and Pastes
Run Lipsum for all objects, and note that it has much less failure.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This looks like it has some 4-space indents. In this project, for consistency, prefer 2-space indents.
I added you to Community (granting you sweeping janitorial powers on this install) and Blessed Committers, allowing you to land this yourself. That project's description has some instructions for pushing. Yell if you run into trouble.
Comment Actions
@epriestley Thank you very much. I've landed this patch. I've got a few more things I've discovered I'll be submitting for review as well. I'll make sure to use two spaces instead of four (I think this is because PhpStorm sets a 'continuation indent' to four and not two)