Page MenuHomePhabricator
Feed Advanced Search

Dec 12 2015

pritambaral added a comment to T9972: Profile image from Google not being picked up.

I haven't been able to trace the cause of the issue, but I do have something to add:

Dec 12 2015, 6:42 PM · Auth, Bug Report
pritambaral added a comment to T9972: Profile image from Google not being picked up.

I don't see any way in the code that it can possibly render src="PHID-FILE-...", am I misunderstanding?

Ah, please ignore my comment about the src, it was misinformed.

Dec 12 2015, 4:58 PM · Auth, Bug Report
pritambaral added a comment to T9972: Profile image from Google not being picked up.

Minor issue still present. On the "confirm registration" page, the image shown is still a blank one. (Inspecting the element in browser shows its src = PHID-FILE...)

Dec 12 2015, 4:27 PM · Auth, Bug Report
pritambaral added a comment to T9972: Profile image from Google not being picked up.

Thanks for the exceptionally clear report

Dec 12 2015, 4:17 PM · Auth, Bug Report
pritambaral added a comment to T9972: Profile image from Google not being picked up.

The Google+ API for a person, available for reference at https://developers.google.com/+/web/api/rest/latest/people#resource, does not agree with what libphutil's PhutilGoogleAuthAdapter.php does currently to extract a profile pic.

Dec 12 2015, 2:21 PM · Auth, Bug Report
pritambaral created T9972: Profile image from Google not being picked up.
Dec 12 2015, 2:14 PM · Auth, Bug Report