Page MenuHomePhabricator
Feed Advanced Search

May 13 2016

metellius added a comment to T6055: arcanist/phabricator should support commit messages without "Summary:" header.
In T6055#175114, @hvr wrote:

@metellius I tried your patch, but I hit the same issue; arc diff reports an Invalid or missing field "Test Plan"; I guess I need to tweak something in the commit msg parser... you didn't need that?

May 13 2016, 10:07 AM
metellius added a comment to T6055: arcanist/phabricator should support commit messages without "Summary:" header.

the part in the reviewed-by field is in relation to another commit that makes it look like "Reviewed-by: ..." instead of "Reviewed by\n..."

May 13 2016, 7:06 AM
metellius added a comment to T6055: arcanist/phabricator should support commit messages without "Summary:" header.

It's been a long time since I looked at our custom patches, but I do believe this is the one that did it for us:

May 13 2016, 7:04 AM

Oct 24 2014

metellius added a comment to T6387: People that have an account but are not actively using phabricator should not receive emails for every commit they do.

Not sure I understand what you mean by saying it's running on modern infrastructure?

Oct 24 2014, 3:35 PM · Diffusion, Audit
metellius added a comment to T6387: People that have an account but are not actively using phabricator should not receive emails for every commit they do.

Don't think so, I just added them using the LDAP import page, and they work as normal accounts for people who need to do something in phabricator.

Oct 24 2014, 1:39 PM · Diffusion, Audit
metellius created T6387: People that have an account but are not actively using phabricator should not receive emails for every commit they do.
Oct 24 2014, 12:28 PM · Diffusion, Audit

Sep 22 2014

metellius created T6161: Support for "partially accepted" revisions.
Sep 22 2014, 6:35 PM · Differential

Sep 9 2014

metellius closed T6055: arcanist/phabricator should support commit messages without "Summary:" header as Wontfix.

Thanks! That's just what I was looking for.

Sep 9 2014, 5:44 PM
metellius added a comment to T6055: arcanist/phabricator should support commit messages without "Summary:" header.

I see your point.

Sep 9 2014, 5:28 PM
metellius created T6055: arcanist/phabricator should support commit messages without "Summary:" header.
Sep 9 2014, 8:09 AM

Aug 7 2014

metellius added a comment to T5815: Make it easier to work through a queue of stuff.

Realistically, one guy handling a series of up to 10 commits will not be a rare occurance; if you start auditing a commit series it doesn't really make sense to just quit in the middle.

Aug 7 2014, 8:29 PM · Restricted Project, Maniphest, Differential, Audit
metellius added a comment to T5815: Make it easier to work through a queue of stuff.
In T5815#8, @chad wrote:

I don't want to comment on this specifically, just that as a product designer I hesitate when deciding between making things super easy (less quality) or some friction (pause and reset mindset). Friction isn't a bad thing, especially when you need more information or more thorough review. Because Phabricator is a tool for completing quality work, making things too easy seems not as important over ensuring some quality.

Aug 7 2014, 5:49 PM · Restricted Project, Maniphest, Differential, Audit
metellius lowered the priority of T2542: Provide a link from revisions that are blamees to their blamers from Normal to Low.
Aug 7 2014, 4:03 PM · Diffusion, Audit, Differential
metellius raised the priority of T2542: Provide a link from revisions that are blamees to their blamers from Low to Normal.
Aug 7 2014, 4:03 PM · Diffusion, Audit, Differential
metellius added a comment to T5815: Make it easier to work through a queue of stuff.

That wouldn't really change much, it might even be annoying at times since you typically read through the commit all the way to the bottom, and typically that is the point in time where you want to accept the commit.

Aug 7 2014, 3:16 PM · Restricted Project, Maniphest, Differential, Audit
metellius created T5815: Make it easier to work through a queue of stuff.
Aug 7 2014, 11:13 AM · Restricted Project, Maniphest, Differential, Audit