Page MenuHomePhabricator
Create Task
Maniphest T6387

People that have an account but are not actively using phabricator should not receive emails for every commit they do
Closed, ResolvedPublic
Actions

Description

Since upgrading phabricator today, every user including people with imported accounts suddenly started getting notification emails from Phabricator about their commits, regardless of whether they touched any of our audit-triggering paths or herald rules.

In my opinion, it should be possible to import lots of users and not have them disturbed unless someone actively interacts with them through Phabricator (ie reviews, audit raised concerns, etc).

I could not find any way to globally disable this particular email notification, and with people pressing me to start the only solution I could find was to mysql-insert '{"mailtags":{"audit-commit":0}}' as a default user preference for everyone.

Event Timeline

metellius created this task.Oct 24 2014, 12:28 PM
metellius raised the priority of this task from to Needs Triage.
metellius updated the task description. (Show Details)
metellius added projects: Audit, Diffusion.
metellius added a subscriber: metellius.
cburroughs added a subscriber: cburroughs.Oct 24 2014, 1:25 PM

Are these disabled accounts receiving the email?

metellius added a comment.Oct 24 2014, 1:39 PM

Don't think so, I just added them using the LDAP import page, and they work as normal accounts for people who need to do something in phabricator.

chad closed this task as Resolved.Oct 24 2014, 2:29 PM
chad claimed this task.

Audit is now running on modern infrastructure and is consistent will all other Phabricator applications.

If they are not a user, you can disabled their accounts. If they are, they can change their email presences in Settings under Audit.

metellius added a comment.Oct 24 2014, 3:35 PM

Not sure I understand what you mean by saying it's running on modern infrastructure?

These people are not disabled users in the sense that they should be able to login and and should absolutely receive email when they interact or are interacted with through phabricator. The exception here is creating commits, because that's something that on an external repository frequently happens without having anything to do phabricator.

You say "they can change their email presence", and this is of course true, but we're trying hard to keep phabricator an opt-in tool instead of showering people with emails from something they don't use (yet, the ones who do discover phabricator consistently end up liking it).

The simplest and best solution would be if it was possible to set a default email policy, or even simpler just being able to set a json-hash with default user preferences in the configuration. I could find no such option or command, so that's why I ended up doing it manually in the database.

chad added a subscriber: chad.Oct 24 2014, 4:01 PM

Audit previously ran older code that was inconsistent with how every other application works. That had been fixed and new user preferences were added in support. We don't have any plans to offer admins additional defaults to set for users (are there any?). Event listeners already exist for things like registration and are infinitly more flexible.

Vanilla Phabricator send lots of emails, and it is our intent that developers will individually manage and groom these as best match their workflow. This is a developer feature/preference in our opinion, not an admins.

Phabricator · Built by Phacility