Page MenuHomePhabricator
Feed Advanced Search

Mar 7 2014

leebyron added a comment to T4570: ArcanistLinterTestCase::executeTestsInDirectory() should fail when it finds 0 tests..

Ah I see you did that too :)

Mar 7 2014, 7:30 PM · Arcanist
leebyron updated subscribers of T4570: ArcanistLinterTestCase::executeTestsInDirectory() should fail when it finds 0 tests..

Thanks for the quick response @epriestley! I agree with you that the general case of failing a test when nothing was asserted is a good idea. I think it still may be a good idea for this particular case to have a clear error message, but at least now we're failing fast.

Mar 7 2014, 7:23 PM · Arcanist
leebyron assigned T4570: ArcanistLinterTestCase::executeTestsInDirectory() should fail when it finds 0 tests. to epriestley.
Mar 7 2014, 4:49 AM · Arcanist