Page MenuHomePhabricator
Feed Advanced Search

Jan 9 2017

durin42 added a comment to T10382: Transaction abort when pushing via SSH to a Mercurial repository.

Note that my suggestion in https://secure.phabricator.com/T10382#191728 is still what I think /should/ happen: if Phabricator insists on trying to parse the Mercurial protocol, it should absolutely not include capabilities it doesn't understand when queried by the client.

Jan 9 2017, 2:04 AM · Mercurial, Bug Report

Aug 25 2016

durin42 added a comment to T9548: Support Mercurial's bundle2 wire protocol.

It's not entirely phabricator specific, as others probably have similar use cases. I'm literally the only hg dev that knows this is an issue (someone flagged me on twitter a month ago, and it's only a strange inability to sleep tonight that got me deep enough in my stack taht I got to this), but if you go to our ML with a decent problem statement ("we need a hook to let us identify read vs write transactions and do our own ACL checking" sounds like a start?) you'll get more help than just me when I'm unable to sleep. :)

Aug 25 2016, 4:31 AM · Diffusion, Mercurial
durin42 added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Ah, okay. We can probably do a lot better with some sort of pre-transaction hook then (that was my gut feeling to begin with). Once you've got an idea what the use case is, maybe we can chat on the hg mailing list?

Aug 25 2016, 4:24 AM · Diffusion, Mercurial
durin42 added a comment to T9548: Support Mercurial's bundle2 wire protocol.

We've got a volunteer (slowly) working on documenting formats, but right now bundle2 is not documented extensively outside of the code and the wiki page already mentioned in this thread.

Aug 25 2016, 4:19 AM · Diffusion, Mercurial
durin42 added a comment to T9548: Support Mercurial's bundle2 wire protocol.

I'm not sure why phabricator is trying to parse the bundle stream (I don't know anything about phabricator), but you should be able to invoke hg with bundle2 disabled by setting experimental.bundle2-advertise to false in an hgrc (or using --config if you're shelling out to hg). Given that it's an experimental flag, it's not something I can promise will exist forever, but it might be a start.

Aug 25 2016, 4:13 AM · Diffusion, Mercurial
durin42 added a comment to T10382: Transaction abort when pushing via SSH to a Mercurial repository.

So, yes, the bundle2 thing is definitely orthogonal to this. For now, I'd suggest that if phabricator breaks bundle2, filter the response to the capabilities command and omit bundle2=.* from the response.

Aug 25 2016, 4:06 AM · Mercurial, Bug Report