More perusing through Phabricator to find and address incompatibilities.
Refs T13588
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T13588: PHP 8 Compatibility
- Commits
- rP40b272fa51ea: Addressing PHP8 incompatibilities - Miscellaneous
- Creating macros, changing their text.
- Upload to use existing SSH key instead of generate one.
- Modify alt text of an uploaded file.
- Create phame post
- Delete phriction document
- Move tasks around on workboard, assign story points
- Generate Diviner docs
- Bulk modify tasks
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- cspeck-php8-misc
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 25824 Build 35652: arc lint + arc unit
Event Timeline
Comment Actions
One actual logical issue inline.
| scripts/repository/commit_hook.php | ||
|---|---|---|
| 122 | This incorrectly prevents use of the common and desirable username "0". (A user with this wholly reasonable username has a registered account on this server and has contributed to Phabricator in the past.) | |
| scripts/repository/commit_hook.php | ||
|---|---|---|
| 122 | 👀 | |