Page MenuHomePhabricator

Addressing PHP8 incompatibilities - Miscellaneous
ClosedPublic

Authored by cspeckmim on May 29 2023, 11:38 PM.
Tags
None
Referenced Files
F14087238: D21869.diff
Sat, Nov 23, 8:14 PM
Unknown Object (File)
Thu, Nov 21, 7:46 PM
Unknown Object (File)
Thu, Nov 21, 7:31 PM
Unknown Object (File)
Fri, Nov 15, 11:37 AM
Unknown Object (File)
Thu, Nov 14, 4:23 PM
Unknown Object (File)
Tue, Oct 29, 7:24 PM
Unknown Object (File)
Oct 24 2024, 1:57 AM
Unknown Object (File)
Oct 24 2024, 1:57 AM
Subscribers

Details

Summary

More perusing through Phabricator to find and address incompatibilities.

Refs T13588

Test Plan
  • Creating macros, changing their text.
  • Upload to use existing SSH key instead of generate one.
  • Modify alt text of an uploaded file.
  • Create phame post
  • Delete phriction document
  • Move tasks around on workboard, assign story points
  • Generate Diviner docs
  • Bulk modify tasks

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cspeckmim held this revision as a draft.

One actual logical issue inline.

scripts/repository/commit_hook.php
122

This incorrectly prevents use of the common and desirable username "0".

(A user with this wholly reasonable username has a registered account on this server and has contributed to Phabricator in the past.)

This revision is now accepted and ready to land.May 30 2023, 2:34 PM
scripts/repository/commit_hook.php
122

👀

Correct the check for an empty username

This revision is now accepted and ready to land.May 30 2023, 3:21 PM