Page MenuHomePhabricator

Addressing some PHP8 incompatibilities - Misc. Applications
ClosedPublic

Authored by cspeckmim on May 29 2023, 3:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 5:54 PM
Unknown Object (File)
Tue, Nov 26, 7:44 AM
Unknown Object (File)
Sun, Nov 24, 12:01 AM
Unknown Object (File)
Fri, Nov 22, 3:39 PM
Unknown Object (File)
Thu, Nov 21, 7:39 PM
Unknown Object (File)
Thu, Nov 21, 3:14 PM
Unknown Object (File)
Mon, Nov 18, 7:21 AM
Unknown Object (File)
Thu, Nov 14, 12:16 PM
Subscribers

Details

Summary

Browsing through all other non-prototype applications and using them a bit to track down PHP8 incompatibilities.

Refs T13588

Test Plan

I tried basic usage of the following applications which found & fixed:

  • Almanac, creating resources, networks, services, etc.
  • Drydock, creating blue prints
  • Pholio mocks
  • Setting up TOTP MFA
  • Phame blog and post
  • Creating default Space
  • Creating and signing a legalpad document
  • Creating a conpherence room

Diff Detail

Repository
rP Phabricator
Branch
cspeck-php8-apps
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25821
Build 35649: arc lint + arc unit

Event Timeline

cspeckmim held this revision as a draft.

Found a few incompatibilities with Conpherence

Ran all unit tests, found a few more PHP8 incompatibilities with mail.

cspeckmim edited the summary of this revision. (Show Details)
epriestley added inline comments.
src/applications/metamta/exception/PhabricatorMetaMTAReceivedMailProcessingException.php
17 ↗(On Diff #52163)

(This requires PHP 5.5, but so does Phabricator after T13492, so this should be fine.)

This revision is now accepted and ready to land.May 29 2023, 4:28 AM
src/applications/metamta/exception/PhabricatorMetaMTAReceivedMailProcessingException.php
17 ↗(On Diff #52163)

buh - the error I got from this led me to https://php.watch/versions/8.2/partially-supported-callable-deprecation. The backwards-compat notice at the bottom mentions ::class notation is available in 5.3+. I tried messing around with this in https://3v4l.org/E9eTR#v5.4.0 but nothing immediately stood out to me as functional in both 5.4 and 8.2.