Paths

Table of Contentst

Differential D21868

Addressing some PHP8 incompatibilities - Misc. Applications
ClosedPublic
Actions

Authored by cspeckmim on May 29 2023, 3:50 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 28, 3:53 PM

	Unknown Object (File)
	Tue, Nov 26, 5:54 PM

	Unknown Object (File)
	Tue, Nov 26, 7:44 AM

	Unknown Object (File)
	Sun, Nov 24, 12:01 AM

	Unknown Object (File)
	Fri, Nov 22, 3:39 PM

	Unknown Object (File)
	Thu, Nov 21, 7:39 PM

	Unknown Object (File)
	Thu, Nov 21, 3:14 PM

	Unknown Object (File)
	Mon, Nov 18, 7:21 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13588: PHP 8 Compatibility

Commits

rPcf400694c717: Addressing some PHP8 incompatibilities - Misc. Applications

Summary

Browsing through all other non-prototype applications and using them a bit to track down PHP8 incompatibilities.

Test Plan

I tried basic usage of the following applications which found & fixed:

Almanac, creating resources, networks, services, etc.
Drydock, creating blue prints
Pholio mocks
Setting up TOTP MFA
Phame blog and post
Creating default Space
Creating and signing a legalpad document
Creating a conpherence room

Diff Detail

Repository

Branch

cspeck-php8-apps

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25822
Build 35650: arc lint + arc unit

Event Timeline

cspeckmim created this revision.May 29 2023, 3:50 AM

cspeckmim held this revision as a draft.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2023, 3:50 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B25821: Diff 52160.May 29 2023, 3:50 AM

Found a few incompatibilities with Conpherence

Harbormaster completed remote builds in B25822: Diff 52161.May 29 2023, 3:56 AM

cspeckmim edited the test plan for this revision. (Show Details)May 29 2023, 4:00 AM

Ran all unit tests, found a few more PHP8 incompatibilities with mail.

Harbormaster completed remote builds in B25823: Diff 52163.May 29 2023, 4:19 AM

cspeckmim published this revision for review.May 29 2023, 4:21 AM

cspeckmim edited the summary of this revision. (Show Details)

epriestley accepted this revision.May 29 2023, 4:28 AM

epriestley added inline comments.

src/applications/metamta/exception/PhabricatorMetaMTAReceivedMailProcessingException.php
17 ↗	(On Diff #52163)	(This requires PHP 5.5, but so does Phabricator after T13492, so this should be fine.)

This revision is now accepted and ready to land.May 29 2023, 4:28 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 29 2023, 4:28 AM

cspeckmim added inline comments.May 29 2023, 1:10 PM

src/applications/metamta/exception/PhabricatorMetaMTAReceivedMailProcessingException.php
17 ↗	(On Diff #52163)	buh - the error I got from this led me to https://php.watch/versions/8.2/partially-supported-callable-deprecation. The backwards-compat notice at the bottom mentions `::class` notation is available in 5.3+. I tried messing around with this in https://3v4l.org/E9eTR#v5.4.0 but nothing immediately stood out to me as functional in both 5.4 and 8.2.

Closed by commit rPcf400694c717: Addressing some PHP8 incompatibilities - Misc. Applications (authored by cspeckmim). · Explain WhyMay 29 2023, 2:41 PM

This revision was automatically updated to reflect the committed changes.

cspeckmim added a commit: rPcf400694c717: Addressing some PHP8 incompatibilities - Misc. Applications.

cspeckmim edited the summary of this revision. (Show Details)May 30 2023, 3:35 PM

cspeckmim added a task: T13588: PHP 8 Compatibility.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

controller/

AlmanacPropertyEditController.php

2 lines

auth/

controller/

mfa/

PhabricatorAuthFactorProviderViewController.php

2 lines

factor/

PhabricatorAuthFactor.php

2 lines

storage/

PhabricatorAuthChallenge.php

3 lines

conpherence/

query/

ConpherenceThreadQuery.php

7 lines

ConpherenceThreadSearchEngine.php

4 lines

diviner/

query/

DivinerBookQuery.php

4 lines

passphrase/

view/

PassphraseCredentialControl.php

4 lines

phame/

storage/

2 lines

pholio/

controller/

PholioImageUploadController.php

2 lines

spaces/

xaction/

PhabricatorSpacesNamespaceNameTransaction.php

2 lines

transactions/

storage/

PhabricatorModularTransactionType.php

2 lines

infrastructure/

customfield/

standard/

PhabricatorStandardCustomFieldPHIDs.php

2 lines

Diff 52161

src/applications/almanac/controller/AlmanacPropertyEditController.php

Loading...

src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php

Loading...

src/applications/auth/factor/PhabricatorAuthFactor.php

Loading...

src/applications/auth/storage/PhabricatorAuthChallenge.php

Loading...

src/applications/conpherence/query/ConpherenceThreadQuery.php

Loading...

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Loading...

src/applications/diviner/query/DivinerBookQuery.php

Loading...

src/applications/passphrase/view/PassphraseCredentialControl.php

Loading...

src/applications/phame/storage/PhameBlog.php

Loading...

src/applications/pholio/controller/PholioImageUploadController.php

Loading...

src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php

Loading...

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...