Page MenuHomePhabricator
Differential D21839

Pass "object" to modular transaction methods explicitly
ClosedPublic
Actions

Authored by epriestley on May 25 2022, 5:18 PM.
Tags
None
Referenced Files
F13243544: D21839.diff
Thu, May 23, 4:01 AM
F13221968: D21839.diff
Sun, May 19, 3:13 AM
F13204572: D21839.diff
Wed, May 15, 12:43 AM
F13198326: D21839.diff
Mon, May 13, 5:47 AM
F13187670: D21839.diff
Sat, May 11, 4:40 AM
F13186099: D21839.diff
Sat, May 11, 3:25 AM
F13183040: D21839.diff
Fri, May 10, 6:25 AM
Unknown Object (File)
Tue, May 7, 7:53 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP5aa159a83013: Pass "object" to modular transaction methods explicitly
Summary

Ref T13682. When editing a comment, the edit pathway may invoke file PHID extraction without first formalizing an object on the Editor.

Pass the "object" explicitly to generally improve the robustness of this pathway.

Test Plan

Edited a comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 25 2022, 5:18 PM
epriestley created this revision.
Harbormaster completed remote builds in B25746: Diff 52052.May 25 2022, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 25 2022, 5:25 PM
Closed by commit rP5aa159a83013: Pass "object" to modular transaction methods explicitly (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP5aa159a83013: Pass "object" to modular transaction methods explicitly.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
48 lines

Diff 52053

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility