Pass "object" to modular transaction methods explicitly
ClosedPublic
Actions

Authored by epriestley on May 25 2022, 5:18 PM.

Tags

None

Referenced Files

	F15524871: D21839.id52052.diff
	Mon, Apr 21, 10:54 AM

	F15511009: D21839.diff
	Wed, Apr 16, 11:21 PM

	F15508159: D21839.id52052.diff
	Wed, Apr 16, 2:28 AM

	F15503025: D21839.diff
	Mon, Apr 14, 6:09 AM

	F15467624: D21839.id52052.diff
	Thu, Apr 3, 5:00 PM

	F15451609: D21839.id52053.diff
	Fri, Mar 28, 10:58 PM

	F15451601: D21839.id52052.diff
	Fri, Mar 28, 10:56 PM

	F15451599: D21839.id.diff
	Fri, Mar 28, 10:56 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP5aa159a83013: Pass "object" to modular transaction methods explicitly

Summary

Ref T13682. When editing a comment, the edit pathway may invoke file PHID extraction without first formalizing an object on the Editor.

Pass the "object" explicitly to generally improve the robustness of this pathway.

Test Plan

Edited a comment.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 25 2022, 5:18 PM

epriestley created this revision.

Harbormaster completed remote builds in B25746: Diff 52052.May 25 2022, 5:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 25 2022, 5:25 PM

Closed by commit rP5aa159a83013: Pass "object" to modular transaction methods explicitly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5aa159a83013: Pass "object" to modular transaction methods explicitly.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

48 lines

Diff 52053

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Pass "object" to modular transaction methods explicitlyClosedPublicActions