Pass "object" to modular transaction methods explicitly
ClosedPublic
Actions

Authored by epriestley on May 25 2022, 5:18 PM.

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP5aa159a83013: Pass "object" to modular transaction methods explicitly

Summary

Ref T13682. When editing a comment, the edit pathway may invoke file PHID extraction without first formalizing an object on the Editor.

Pass the "object" explicitly to generally improve the robustness of this pathway.

Test Plan

Edited a comment.

Repository

rP Phabricator

Branch

editor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25746
Build 35574: arc lint + arc unit

epriestley requested review of this revision.May 25 2022, 5:18 PM

epriestley created this revision.

This revision was not accepted when it landed; it landed in state Needs Review.May 25 2022, 5:25 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

transactions/

editor/

48 lines