Page MenuHomePhabricator
Differential D21827

Give "RemarkupControl" support for tracking metadata
ClosedPublic
Actions

Authored by epriestley on May 19 2022, 6:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 11:25 PM
Unknown Object (File)
Mon, Apr 29, 4:40 AM
Unknown Object (File)
Sat, Apr 27, 11:58 PM
Unknown Object (File)
Mon, Apr 22, 10:46 PM
Unknown Object (File)
Sat, Apr 20, 5:58 PM
Unknown Object (File)
Sat, Apr 20, 3:59 PM
Unknown Object (File)
Fri, Apr 19, 7:58 AM
Unknown Object (File)
Tue, Apr 16, 12:51 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP33a0731619e8: Give "RemarkupControl" support for tracking metadata
Summary

Ref T13603. This will support explicit handling of attached files.

Test Plan

Adjusted new input to have "text" input type, used it alongside additional upcoming changes, saw sensible metadata behavior.

Diff Detail

Repository
rP Phabricator
Branch
remarkup1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/core/behavior-drag-and-drop-textarea.js:17W098JSHintW098
Warningwebroot/rsrc/js/core/behavior-drag-and-drop-textarea.js:22W098JSHintW098
Unit
Tests Passed
Build Status
Buildable 25728
Build 35556: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 19 2022, 6:22 PM
epriestley created this revision.
Harbormaster completed remote builds in B25727: Diff 52012.May 19 2022, 6:22 PM
epriestley updated this revision to Diff 52013.May 19 2022, 6:44 PM
  • Slightly smaller API, because versioned drafts are not coupled to form inputs.
Harbormaster completed remote builds in B25728: Diff 52013.May 19 2022, 6:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 7:03 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP33a0731619e8: Give "RemarkupControl" support for tracking metadata (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP33a0731619e8: Give "RemarkupControl" support for tracking metadata.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
view/
form/
control/
32 lines
webroot/
rsrc/
js/
core/
16 lines

Diff 52013

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js

Loading...
Phabricator · Built by Phacility