Remove "feed.publish" API
ClosedPublic
Actions

Authored by epriestley on May 17 2022, 11:29 PM.

Details

Reviewers: None
Maniphest Tasks: T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable
Commits: rP431612023dae: Remove "feed.publish" API

Summary

Ref T13681. This was introduced in D593, never used, and doesn't make sense or have any uses in modern Phabricator.

It also does some pretty direct writes that can technically do things that at least look like they violate policies, so remove it.

Test Plan

Checked the API console, no longer saw "feed.publish".
Grepped for "feed.publish", no hits.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 17 2022, 11:29 PM

epriestley created this revision.

Harbormaster completed remote builds in B25725: Diff 52008.May 17 2022, 11:29 PM

Include library map update.

Harbormaster completed remote builds in B25726: Diff 52009.May 17 2022, 11:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 17 2022, 11:31 PM

Closed by commit rP431612023dae: Remove "feed.publish" API (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP431612023dae: Remove "feed.publish" API.

epriestley mentioned this in T13700: Notes to Self, Late 2023.Nov 13 2023, 6:28 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

feed/

conduit/

FeedPublishConduitAPIMethod.php

Diff 52010

View Options

src/__phutil_library_map__.php