Ref T13681. This was introduced in D593, never used, and doesn't make sense or have any uses in modern Phabricator.
It also does some pretty direct writes that can technically do things that at least look like they violate policies, so remove it.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable
- Commits
- rP431612023dae: Remove "feed.publish" API
- Checked the API console, no longer saw "feed.publish".
- Grepped for "feed.publish", no hits.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- feed1
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 25725 Build 35553: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 1 ms | PhabricatorConduitTestCase::testConduitMethods EXCEPTION (Exception): Source file "/Users/epriestley/dev/core/lib/phabricator/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php" failed to load.
#0 /Users/epriestley/dev/core/lib/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/Users/epriestl...')
#1 /Users/epriestley/dev/core/lib/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phabricator', 'applications/fe...')
| |
| 491 ms | PhabricatorLibraryTestCase::testEverythingImplemented EXCEPTION (Exception): Source file "/Users/epriestley/dev/core/lib/phabricator/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php" failed to load.
#0 /Users/epriestley/dev/core/lib/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/Users/epriestl...')
#1 /Users/epriestley/dev/core/lib/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phabricator', 'applications/fe...')
| |
| 230 ms | PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`.
These entries differ: class.FeedPublishConduitAPIMethod, xmap.FeedPublishConduitAPIMethod.
| |
| 190 ms | PhabricatorLibraryTestCase::testMethodVisibility EXCEPTION (Exception): Source file "/Users/epriestley/dev/core/lib/phabricator/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php" failed to load.
#0 /Users/epriestley/dev/core/lib/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/Users/epriestl...')
#1 /Users/epriestley/dev/core/lib/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phabricator', 'applications/fe...')
| |
| 200 ms | PhabricatorCelerityTestCase::testCelerityMaps 3 assertions passed. | |
| View Full Test Results (4 Failed · 3 Passed) |