Page MenuHomePhabricator

Remove "feed.publish" API
ClosedPublic

Authored by epriestley on May 17 2022, 11:29 PM.
Tags
None
Referenced Files
F11042333: D21826.diff
Tue, Aug 16, 7:01 PM
F11039773: D21826.diff
Tue, Aug 16, 6:48 AM
Unknown Object (File)
Fri, Aug 12, 2:36 PM
Unknown Object (File)
Fri, Aug 12, 10:30 AM
Unknown Object (File)
Wed, Aug 10, 12:57 PM
Unknown Object (File)
Tue, Jul 26, 3:30 PM
Unknown Object (File)
Sun, Jul 24, 4:31 AM
Unknown Object (File)
Sun, Jul 24, 4:31 AM
Subscribers
None

Details

Summary

Ref T13681. This was introduced in D593, never used, and doesn't make sense or have any uses in modern Phabricator.

It also does some pretty direct writes that can technically do things that at least look like they violate policies, so remove it.

Test Plan
  • Checked the API console, no longer saw "feed.publish".
  • Grepped for "feed.publish", no hits.

Diff Detail

Repository
rP Phabricator
Branch
feed1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25725
Build 35553: arc lint + arc unit

Unit TestsFailed

TimeTest
1 msPhabricatorConduitTestCase::testConduitMethods
EXCEPTION (Exception): Source file "/Users/epriestley/dev/core/lib/phabricator/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php" failed to load. #0 /Users/epriestley/dev/core/lib/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/Users/epriestl...') #1 /Users/epriestley/dev/core/lib/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phabricator', 'applications/fe...')
491 msPhabricatorLibraryTestCase::testEverythingImplemented
EXCEPTION (Exception): Source file "/Users/epriestley/dev/core/lib/phabricator/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php" failed to load. #0 /Users/epriestley/dev/core/lib/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/Users/epriestl...') #1 /Users/epriestley/dev/core/lib/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phabricator', 'applications/fe...')
230 msPhabricatorLibraryTestCase::testLibraryMap
Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: class.FeedPublishConduitAPIMethod, xmap.FeedPublishConduitAPIMethod.
190 msPhabricatorLibraryTestCase::testMethodVisibility
EXCEPTION (Exception): Source file "/Users/epriestley/dev/core/lib/phabricator/src/applications/feed/conduit/FeedPublishConduitAPIMethod.php" failed to load. #0 /Users/epriestley/dev/core/lib/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/Users/epriestl...') #1 /Users/epriestley/dev/core/lib/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phabricator', 'applications/fe...')
200 msPhabricatorCelerityTestCase::testCelerityMaps
3 assertions passed.
View Full Test Results (4 Failed · 3 Passed)

Event Timeline

epriestley created this revision.
  • Include library map update.
This revision was not accepted when it landed; it landed in state Needs Review.May 17 2022, 11:31 PM
This revision was automatically updated to reflect the committed changes.