Differential D21824

Fix an exception in cursor pagination of Conpherence threads
ClosedPublic
Actions

Authored by epriestley on May 17 2022, 11:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 4, 10:50 PM

	Unknown Object (File)
	Sat, May 4, 10:44 AM

	Unknown Object (File)
	Fri, May 3, 6:12 AM

	Unknown Object (File)
	Thu, May 2, 7:15 PM

	Unknown Object (File)
	Mon, Apr 29, 9:33 AM

	Unknown Object (File)
	Sat, Apr 27, 2:23 AM

	Unknown Object (File)
	Thu, Apr 25, 1:03 AM

	Unknown Object (File)
	Sat, Apr 20, 5:58 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception
Commits: rP147b48b934b3: Fix an exception in cursor pagination of Conpherence threads

Summary

Ref T13680. Conpherence may pass values with an integer type to this layer of the stack. These are "supposed" to be strings, but just be accepting.

Test Plan

Wrote 100+ messages to a Conpherence room.
Clicked "Show Older Messages".
Before: exception, int passed to "phutil_nonempty_string()".
After: older messages loaded.

Diff Detail

Repository

Branch

paging1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25723
Build 35551: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 17 2022, 11:08 PM

epriestley created this revision.

Harbormaster completed remote builds in B25723: Diff 52004.May 17 2022, 11:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 17 2022, 11:31 PM

Closed by commit rP147b48b934b3: Fix an exception in cursor pagination of Conpherence threads (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP147b48b934b3: Fix an exception in cursor pagination of Conpherence threads.

epriestley mentioned this in T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception.May 19 2022, 5:33 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

11 lines

Diff 52004

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...