Page MenuHomePhabricator

Fix an exception in cursor pagination of Conpherence threads
ClosedPublic

Authored by epriestley on May 17 2022, 11:08 PM.
Tags
None
Referenced Files
F13344671: D21824.diff
Fri, Jun 21, 8:26 AM
F13332589: D21824.diff
Mon, Jun 17, 3:14 PM
F13330668: D21824.diff
Mon, Jun 17, 4:22 AM
F13326785: D21824.diff
Sat, Jun 15, 8:51 AM
F13317799: D21824.diff
Thu, Jun 13, 9:54 AM
F13304954: D21824.diff
Sat, Jun 8, 3:06 PM
F13288609: D21824.diff
Tue, Jun 4, 10:40 AM
F13270370: D21824.id52011.diff
Wed, May 29, 9:34 AM
Subscribers
None

Details

Summary

Ref T13680. Conpherence may pass values with an integer type to this layer of the stack. These are "supposed" to be strings, but just be accepting.

Test Plan
  • Wrote 100+ messages to a Conpherence room.
  • Clicked "Show Older Messages".
  • Before: exception, int passed to "phutil_nonempty_string()".
  • After: older messages loaded.

Diff Detail

Repository
rP Phabricator
Branch
paging1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25723
Build 35551: arc lint + arc unit