Page MenuHomePhabricator

Fix an exception in cursor pagination of Conpherence threads
ClosedPublic

Authored by epriestley on May 17 2022, 11:08 PM.
Tags
None
Referenced Files
F18371235: D21824.id52011.diff
Thu, Aug 28, 4:52 AM
F18361044: D21824.diff
Wed, Aug 27, 11:20 AM
F18205897: D21824.diff
Mon, Aug 18, 3:13 PM
F18106710: D21824.id.diff
Sun, Aug 10, 11:13 PM
F18086697: D21824.id.diff
Tue, Aug 5, 11:30 PM
F18081706: D21824.diff
Tue, Aug 5, 1:39 AM
F18044834: D21824.id52011.diff
Sun, Aug 3, 7:53 AM
F18011189: D21824.id52004.diff
Sat, Aug 2, 4:09 PM
Subscribers
None

Details

Summary

Ref T13680. Conpherence may pass values with an integer type to this layer of the stack. These are "supposed" to be strings, but just be accepting.

Test Plan
  • Wrote 100+ messages to a Conpherence room.
  • Clicked "Show Older Messages".
  • Before: exception, int passed to "phutil_nonempty_string()".
  • After: older messages loaded.

Diff Detail

Repository
rP Phabricator
Branch
paging1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25723
Build 35551: arc lint + arc unit