Double-write file attachment to old "edge" storage and new "attachment" storage
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 9:34 PM.

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task
Commits: rPd017f3f21021: Double-write file attachment to old "edge" storage and new "attachment" storage

Summary

Ref T13603. This adds a second write to new "attachment" storage to all writers except one in Paste, which creates the file inline.

Test Plan

Updated a macro image, confirmed a write to "attachment" storage (transaction pathway).
Updated a blog profile image, confirmed a write to "attachment" storage (legacy pathway).

Repository

rP Phabricator

Branch

file4

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:407	XHP16	TODO Comment

Unit

Test Failures

Build Status

Buildable 25714
Build 35542: arc lint + arc unit

	Time	Test
	44 ms	PhabricatorFileTestCase::testFileIndirectScramble Assertion failed, expected 'true' (at PhabricatorFileTestCase.php:135): Changing attached object view policy should scramble secret. ACTUAL VALUE
	221 ms	PhabricatorCelerityTestCase::testCelerityMaps 3 assertions passed.
	9 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	96 ms	PhabricatorFileTestCase::testFileDirectScramble 2 assertions passed.
	6 ms	PhabricatorFileTestCase::testFileStorageDelete 1 assertion passed.
		View Full Test Results (1 Failed · 16 Passed)