Page MenuHomePhabricator

Double-write file attachment to old "edge" storage and new "attachment" storage
ClosedPublic

Authored by epriestley on May 12 2022, 9:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 16, 10:21 AM
Unknown Object (File)
Thu, Jun 16, 10:21 AM
Unknown Object (File)
Thu, Jun 16, 10:21 AM
Unknown Object (File)
Mon, Jun 13, 11:00 PM
Unknown Object (File)
Mon, Jun 13, 4:12 PM
Unknown Object (File)
Mon, Jun 13, 1:45 PM
Unknown Object (File)
Sat, Jun 11, 7:15 PM
Unknown Object (File)
Mon, May 30, 4:25 PM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rPd017f3f21021: Double-write file attachment to old "edge" storage and new "attachment" storage
Summary

Ref T13603. This adds a second write to new "attachment" storage to all writers except one in Paste, which creates the file inline.

Test Plan
  • Updated a macro image, confirmed a write to "attachment" storage (transaction pathway).
  • Updated a blog profile image, confirmed a write to "attachment" storage (legacy pathway).

Diff Detail

Repository
rP Phabricator
Branch
file4
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25714
Build 35542: arc lint + arc unit

Unit TestsFailed

TimeTest
44 msPhabricatorFileTestCase::testFileIndirectScramble
Assertion failed, expected 'true' (at PhabricatorFileTestCase.php:135): Changing attached object view policy should scramble secret. ACTUAL VALUE
221 msPhabricatorCelerityTestCase::testCelerityMaps
3 assertions passed.
9 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
96 msPhabricatorFileTestCase::testFileDirectScramble
2 assertions passed.
6 msPhabricatorFileTestCase::testFileStorageDelete
1 assertion passed.
View Full Test Results (1 Failed · 16 Passed)

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.