Page MenuHomePhabricator
Differential D21816

Double-write file attachment to old "edge" storage and new "attachment" storage
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 9:34 PM.
Tags
None
Referenced Files
F13094823: D21816.diff
Thu, Apr 25, 7:33 AM
Unknown Object (File)
Sat, Apr 20, 5:57 PM
Unknown Object (File)
Sat, Apr 20, 4:32 PM
Unknown Object (File)
Fri, Apr 19, 2:51 PM
Unknown Object (File)
Fri, Apr 19, 8:31 AM
Unknown Object (File)
Mon, Apr 15, 10:22 PM
Unknown Object (File)
Sun, Apr 7, 3:02 AM
Unknown Object (File)
Sat, Apr 6, 7:28 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rPd017f3f21021: Double-write file attachment to old "edge" storage and new "attachment" storage
Summary

Ref T13603. This adds a second write to new "attachment" storage to all writers except one in Paste, which creates the file inline.

Test Plan
  • Updated a macro image, confirmed a write to "attachment" storage (transaction pathway).
  • Updated a blog profile image, confirmed a write to "attachment" storage (legacy pathway).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 12 2022, 9:34 PM
epriestley created this revision.
Harbormaster completed remote builds in B25714: Diff 51995.May 12 2022, 9:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was landed with ongoing or failed builds.
Closed by commit rPd017f3f21021: Double-write file attachment to old "edge" storage and new "attachment" storage (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPd017f3f21021: Double-write file attachment to old "edge" storage and new "attachment" storage.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
storage/
20 lines
12 lines
transactions/
constants/
1 line
editor/
295 lines
storage/
7 lines

Diff 52024

View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

src/applications/files/storage/PhabricatorFileAttachment.php

Loading...
View Options

src/applications/transactions/constants/PhabricatorTransactions.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility