Mostly remove "STDERR" and "STDOUT" constants from Arcanist
ClosedPublic
Actions

Authored by epriestley on Apr 28 2022, 10:25 PM.

Details

Reviewers: None
Maniphest Tasks: T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes
T13675: Can Arcanist plausibly be compiled into a binary?
Commits: rARC8d487ed77016: Mostly remove "STDERR" and "STDOUT" constants from Arcanist

Summary

Ref T13675. Ref T13556. The "STDOUT" and "STDERR" constants are defined by the PHP CLI SAPI, in cli_register_file_handles().

The "native arc" embedded PHP wrapper doesn't define these, and there's no real reason to define them, since they're just defined in terms of the PHP stream wrappers ("php://stdin", etc) anyway.

This patch isn't exhaustive (and a subsequent change should add lint, rejecting these magic constants) but is just trying to make native arc functional.

Test Plan

Created this revision with a standalone native arc binary.

Diff Detail

Repository

rARC Arcanist

Branch

stdio

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/filesystem/PhutilErrorLog.php:31	XHP20	Tautological Expression

Unit

Test Failures

Build Status

Buildable 25692
Build 35520: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,193 ms	ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue. #0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n') #1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
	0 ms	AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNoncyclicGraph 1 assertion(s) passed.
		View Full Test Results (1 Failed · 240 Passed)