Ref T13676. When the required "repositories.map" attribute is omitted, bin/drydock lease currently fatals in an unhelpful way when trying to lease a working copy.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13676: Drydock may reclaim recently-used resources
- Commits
- rPd1fd2975b062: Fail in a more comprehensible way when a WorkingCopy lease omits or mangles…
Ran bin/drydock lease --type working-copy with no attributes, after following steps in T13676.
<Allocation Failed> One or more blueprints promised a new resource, but failed when allocating: [PhutilAggregateException] All blueprints failed to allocate a suitable new resource when trying to allocate lease ("PHID-DRYL-orbtwtlinksm3xqpyhmw").
- Exception: Working copy lease is missing required attribute "repositories.map".
Attribute "repositories.map" should be a map of repository specifications.Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- drydock2
- Lint
Lint Passed Severity Location Code Message Advice src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php:157 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 25690 Build 35518: arc lint + arc unit