Page MenuHomePhabricator

Fail in a more comprehensible way when a WorkingCopy lease omits or mangles "repositories.map"
ClosedPublic

Authored by epriestley on May 3 2022, 6:36 PM.
Tags
None
Referenced Files
F13038187: D21796.diff
Mon, Apr 15, 11:20 PM
Unknown Object (File)
Thu, Apr 4, 2:07 AM
Unknown Object (File)
Sun, Mar 31, 7:17 PM
Unknown Object (File)
Mon, Mar 25, 7:33 AM
Unknown Object (File)
Sat, Mar 23, 8:09 PM
Unknown Object (File)
Tue, Mar 19, 5:16 PM
Unknown Object (File)
Mar 16 2024, 11:45 AM
Unknown Object (File)
Mar 4 2024, 6:07 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. When the required "repositories.map" attribute is omitted, bin/drydock lease currently fatals in an unhelpful way when trying to lease a working copy.

Test Plan

Ran bin/drydock lease --type working-copy with no attributes, after following steps in T13676.

<Allocation Failed> One or more blueprints promised a new resource, but failed when allocating: [PhutilAggregateException] All blueprints failed to allocate a suitable new resource when trying to allocate lease ("PHID-DRYL-orbtwtlinksm3xqpyhmw").
    - Exception: Working copy lease is missing required attribute "repositories.map".
      
      Attribute "repositories.map" should be a map of repository specifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable