Page MenuHomePhabricator
Differential D21764

Remove all product name literals in "pht()" in Arcanist
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 4:44 PM.
Tags
None
Referenced Files
F22538424: D21764.id51892.diff
Tue, Sep 22, 9:13 AM
F22530629: D21764.id51900.diff
Mon, Sep 21, 3:13 PM
F22518172: D21764.id51900.diff
Sun, Sep 20, 11:34 AM
F22518171: D21764.id51892.diff
Sun, Sep 20, 11:34 AM
F22518170: D21764.id51883.diff
Sun, Sep 20, 11:34 AM
F22518169: D21764.id.diff
Sun, Sep 20, 11:34 AM
Unknown Object (File)
Wed, Aug 26, 2:52 AM
Unknown Object (File)
Tue, Aug 25, 2:51 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13658: How to rebrand Phabricator
Commits
rARC93cf13cdb963: Remove all product name literals in "pht()" in Arcanist
Summary

Ref T13658. Remove all product name literals from "pht()" strings, by replacing them with generic text where that feels reasonably natural, or "PlatformSymbols" calls elsewhere.

These calls were identified with arc lint --everything after enabling the lint rule in D21763.

Test Plan

Read strings, ran "arc".

Diff Detail

Repository
rARC Arcanist
Branch
product2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25652
Build 35480: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Apr 25 2022, 4:44 PM
epriestley created this revision.
Harbormaster completed remote builds in B25652: Diff 51883.Apr 25 2022, 4:44 PM
epriestley updated this revision to Diff 51892.Apr 25 2022, 6:57 PM
  • Additional PHP 8.1 "strlen(null)" fix.
Harbormaster completed remote builds in B25661: Diff 51892.Apr 25 2022, 6:57 PM
epriestley updated this revision to Diff 51898.Apr 25 2022, 7:20 PM
  • One additional PHP 8.1 fix for float/int precision.
Harbormaster completed remote builds in B25667: Diff 51898.Apr 25 2022, 7:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:21 PM
This revision was landed with ongoing or failed builds.
Closed by commit rARC93cf13cdb963: Remove all product name literals in "pht()" in Arcanist (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC93cf13cdb963: Remove all product name literals in "pht()" in Arcanist.

Revision Contents
Changeset List

Diff 51883

View Options

scripts/arcanist.php

Loading...
View Options

src/conduit/ArcanistConduitEngine.php

Loading...
View Options

src/config/arc/ArcanistArcConfigurationEngineExtension.php

Loading...
View Options

src/configuration/ArcanistBlindlyTrustHTTPEngineExtension.php

Loading...
View Options

src/toolset/ArcanistArcToolset.php

Loading...
View Options

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistCallConduitWorkflow.php

Loading...
View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

Loading...
View Options

src/workflow/ArcanistLiberateWorkflow.php

Loading...
View Options

src/workflow/ArcanistUpgradeWorkflow.php

Loading...
View Options

src/workflow/ArcanistUploadWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility