Page MenuHomePhabricator

Remove all product name literals in "pht()" in Arcanist
ClosedPublic

Authored by epriestley on Apr 25 2022, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 29, 9:15 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Mon, Jun 13, 1:30 PM
Unknown Object (File)
Sat, Jun 11, 12:50 PM
Subscribers
None

Details

Summary

Ref T13658. Remove all product name literals from "pht()" strings, by replacing them with generic text where that feels reasonably natural, or "PlatformSymbols" calls elsewhere.

These calls were identified with arc lint --everything after enabling the lint rule in D21763.

Test Plan

Read strings, ran "arc".

Diff Detail

Repository
rARC Arcanist
Branch
product2
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25667
Build 35495: arc lint + arc unit

Unit TestsFailed

TimeTest
1,119 msArcanistBundleTestCase::testGitRepository
EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue. #0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n') #1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
0 msAbstractDirectedGraphTestCase::testCyclicGraph
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testEdgeLoadFailure
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testNonTreeGraph
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testNoncyclicGraph
1 assertion(s) passed.
View Full Test Results (1 Failed · 169 Passed)

Event Timeline

epriestley created this revision.
  • Additional PHP 8.1 "strlen(null)" fix.
  • One additional PHP 8.1 fix for float/int precision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:21 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.