Page MenuHomePhabricator

Remove all product name literals in "pht()" in Arcanist
ClosedPublic

Authored by epriestley on Apr 25 2022, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 29, 9:15 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Mon, Jun 13, 1:30 PM
Unknown Object (File)
Sat, Jun 11, 12:50 PM
Subscribers
None

Details

Summary

Ref T13658. Remove all product name literals from "pht()" strings, by replacing them with generic text where that feels reasonably natural, or "PlatformSymbols" calls elsewhere.

These calls were identified with arc lint --everything after enabling the lint rule in D21763.

Test Plan

Read strings, ran "arc".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
  • Additional PHP 8.1 "strlen(null)" fix.
  • One additional PHP 8.1 fix for float/int precision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:21 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.