Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration

Summary

Ref T13588. This configuration value may not be set.

Also fix an issue in bin/storage and whatever else I hit between now and this diff actually uploading.

Also fix a MySQLi report mode difference, beginning in PHP 8.1.

Also update a bunch of "static" property usage in Lisk.

Test Plan

Ran bin/files ... locally under PHP 8.1.

Diff Detail

Repository

rP Phabricator

Branch

php81

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25623
Build 35449: Run Core Tests
Build 35448: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 16 2021, 11:07 PM

Harbormaster completed remote builds in B25615: Diff 51829.Dec 16 2021, 11:08 PM

epriestley requested review of this revision.Dec 16 2021, 11:08 PM

Add annotations for interfaces implemented by PhabricatorHandleList.

Harbormaster completed remote builds in B25616: Diff 51830.Dec 16 2021, 11:09 PM

Fix a strlen() in query construction.

Harbormaster completed remote builds in B25617: Diff 51831.Dec 16 2021, 11:10 PM

Correct behavior in query clause construction.

Harbormaster completed remote builds in B25618: Diff 51832.Dec 16 2021, 11:12 PM

Fix a piece of user initializing code for PHP 8.1.

Harbormaster completed remote builds in B25619: Diff 51833.Dec 16 2021, 11:14 PM

Fix a PHP 8.1 issue in user querying.

Fix a PHP 8.1 check in local disk storage engine code.

Harbormaster completed remote builds in B25620: Diff 51834.Dec 16 2021, 11:16 PM

Harbormaster completed remote builds in B25621: Diff 51835.

Fix a PHP 8.1 issue in application search code.

Harbormaster completed remote builds in B25622: Diff 51836.Dec 16 2021, 11:18 PM

Fix another random PHP 8.1 issue.

Harbormaster completed remote builds in B25623: Diff 51837.Dec 16 2021, 11:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 11:24 PM

Closed by commit rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.

Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 51837

.arclint

scripts/sql/manage_storage.php

src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php

src/applications/meta/query/PhabricatorApplicationQuery.php

src/applications/people/query/PhabricatorPeopleQuery.php

src/applications/people/storage/PhabricatorUser.php

src/applications/phid/handle/pool/PhabricatorHandleList.php

src/infrastructure/cluster/PhabricatorDatabaseRef.php

src/infrastructure/query/PhabricatorQuery.php

src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

src/infrastructure/storage/lisk/LiskDAO.php

src/infrastructure/util/PhabricatorHash.php

src/infrastructure/util/PhabricatorMetronome.php

Fix a PHP 8.1 strlen() issue with "mysql.pass" configurationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51837

.arclint

scripts/sql/manage_storage.php

src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php

src/applications/meta/query/PhabricatorApplicationQuery.php

src/applications/people/query/PhabricatorPeopleQuery.php

src/applications/people/storage/PhabricatorUser.php

src/applications/phid/handle/pool/PhabricatorHandleList.php

src/infrastructure/cluster/PhabricatorDatabaseRef.php

src/infrastructure/query/PhabricatorQuery.php

src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

src/infrastructure/storage/lisk/LiskDAO.php

src/infrastructure/util/PhabricatorHash.php

src/infrastructure/util/PhabricatorMetronome.php

Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
ClosedPublic
Actions

Revision Contents
Changeset List