Paths

Table of Contentst

Differential D21744

Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
ClosedPublic
Actions

Authored by epriestley on Dec 16 2021, 11:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 3, 7:56 AM

	Unknown Object (File)
	Jun 17 2025, 8:09 AM

	Unknown Object (File)
	Jun 7 2025, 2:21 AM

	Unknown Object (File)
	May 31 2025, 10:06 PM

	Unknown Object (File)
	May 31 2025, 9:09 AM

	Unknown Object (File)
	May 13 2025, 8:48 PM

	Unknown Object (File)
	May 9 2025, 3:34 AM

	Unknown Object (File)
	May 7 2025, 7:38 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration

Summary

Ref T13588. This configuration value may not be set.

Also fix an issue in bin/storage and whatever else I hit between now and this diff actually uploading.

Also fix a MySQLi report mode difference, beginning in PHP 8.1.

Also update a bunch of "static" property usage in Lisk.

Test Plan

Ran bin/files ... locally under PHP 8.1.

Diff Detail

Repository

Branch

php81

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25615
Build 35433: Run Core Tests
Build 35432: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	699 ms	PhabricatorLibraryTestCase::testEverythingImplemented EXCEPTION (Exception): Error while loading file "/Users/epriestley/dev/core/lib/phabricator/src/applications/phid/handle/pool/PhabricatorHandleList.php": Return type of PhabricatorHandleList::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice #0 /Users/epriestley/dev/core/lib/arcanist/src/init/lib/PhutilBootloader.php(207): PhutilBootloader->executeInclude('/Users/epriestl...') #1 /Users/epriestley/dev/core/lib/arcanist/src/symbols/PhutilSymbolLoader.php(422): PhutilBootloader->loadLibrarySource('phabricator', 'applications/ph...')
	0 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
	0 ms	AphrontHTTPHeaderParserTestCase::testHeaderParser 18 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPHeaderNames 2 assertions passed.
		View Full Test Results (1 Failed · 451 Passed · 2 Skipped)

Event Timeline

epriestley created this revision.Dec 16 2021, 11:07 PM

Harbormaster completed remote builds in B25615: Diff 51829.Dec 16 2021, 11:08 PM

epriestley requested review of this revision.Dec 16 2021, 11:08 PM

Add annotations for interfaces implemented by PhabricatorHandleList.

Harbormaster completed remote builds in B25616: Diff 51830.Dec 16 2021, 11:09 PM

Fix a strlen() in query construction.

Harbormaster completed remote builds in B25617: Diff 51831.Dec 16 2021, 11:10 PM

Correct behavior in query clause construction.

Harbormaster completed remote builds in B25618: Diff 51832.Dec 16 2021, 11:12 PM

Fix a piece of user initializing code for PHP 8.1.

Harbormaster completed remote builds in B25619: Diff 51833.Dec 16 2021, 11:14 PM

Fix a PHP 8.1 issue in user querying.

Fix a PHP 8.1 check in local disk storage engine code.

Harbormaster completed remote builds in B25620: Diff 51834.Dec 16 2021, 11:16 PM

Harbormaster completed remote builds in B25621: Diff 51835.

Fix a PHP 8.1 issue in application search code.

Harbormaster completed remote builds in B25622: Diff 51836.Dec 16 2021, 11:18 PM

Fix another random PHP 8.1 issue.

Harbormaster completed remote builds in B25623: Diff 51837.Dec 16 2021, 11:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 11:24 PM

Closed by commit rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.

Revision Contents
Changeset List

Path

Size

3 lines

scripts/

sql/

manage_storage.php

2 lines

src/

infrastructure/

cluster/

PhabricatorDatabaseRef.php

1 line

storage/

connection/

mysql/

AphrontMySQLiDatabaseConnection.php

7 lines

lisk/

104 lines

Diff 51829

.arclint

Loading...

scripts/sql/manage_storage.php

Loading...

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Loading...

src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

Loading...

src/infrastructure/storage/lisk/LiskDAO.php

Loading...