Page MenuHomePhabricator
Differential D21744

Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
ClosedPublic
Actions

Authored by epriestley on Dec 16 2021, 11:07 PM.
Tags
None
Referenced Files
F15505659: D21744.diff
Tue, Apr 15, 4:43 AM
F15499278: D21744.id51830.diff
Sun, Apr 13, 2:47 PM
F15492853: D21744.id51834.diff
Sat, Apr 12, 6:57 PM
F15492803: D21744.id51829.diff
Sat, Apr 12, 6:31 PM
F15491493: D21744.id51837.diff
Sat, Apr 12, 4:15 AM
F15491412: D21744.id51838.diff
Sat, Apr 12, 3:07 AM
F15491245: D21744.id51832.diff
Sat, Apr 12, 12:47 AM
F15491122: D21744.id51830.diff
Fri, Apr 11, 11:46 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
Summary

Ref T13588. This configuration value may not be set.

Also fix an issue in bin/storage and whatever else I hit between now and this diff actually uploading.

Also fix a MySQLi report mode difference, beginning in PHP 8.1.

Also update a bunch of "static" property usage in Lisk.

Test Plan

Ran bin/files ... locally under PHP 8.1.

Diff Detail

Repository
rP Phabricator
Branch
php81
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25620
Build 35443: Run Core Tests
Build 35442: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
62 msPhabricatorHandlePoolTestCase::testHandlePools
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php(29): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 29) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/files/engine/PhabricatorFileStorageEngine.php(264): PhabricatorLocalDiskFileStorageEngine->canWriteFiles()
0 msAlmanacNamesTestCase::testServiceOrDeviceNames
30 assertions passed.
0 msAlmanacServiceTypeTestCase::testGetAllServiceTypes
1 assertion passed.
0 msAphrontHTTPHeaderParserTestCase::testHeaderParser
18 assertions passed.
0 msAphrontHTTPSinkTestCase::testHTTPHeaderNames
2 assertions passed.
View Full Test Results (1 Failed · 454 Passed · 2 Skipped)

Event Timeline

epriestley created this revision.Dec 16 2021, 11:07 PM
Harbormaster completed remote builds in B25615: Diff 51829.Dec 16 2021, 11:08 PM
epriestley requested review of this revision.Dec 16 2021, 11:08 PM
epriestley updated this revision to Diff 51830.Dec 16 2021, 11:08 PM
  • Add annotations for interfaces implemented by PhabricatorHandleList.
Harbormaster completed remote builds in B25616: Diff 51830.Dec 16 2021, 11:09 PM
epriestley updated this revision to Diff 51831.Dec 16 2021, 11:09 PM
  • Fix a strlen() in query construction.
Harbormaster completed remote builds in B25617: Diff 51831.Dec 16 2021, 11:10 PM
epriestley updated this revision to Diff 51832.Dec 16 2021, 11:11 PM
  • Correct behavior in query clause construction.
Harbormaster completed remote builds in B25618: Diff 51832.Dec 16 2021, 11:12 PM
epriestley updated this revision to Diff 51833.Dec 16 2021, 11:13 PM
  • Fix a piece of user initializing code for PHP 8.1.
Harbormaster completed remote builds in B25619: Diff 51833.Dec 16 2021, 11:14 PM
epriestley updated this revision to Diff 51834.Dec 16 2021, 11:15 PM
  • Fix a PHP 8.1 issue in user querying.
epriestley updated this revision to Diff 51835.Dec 16 2021, 11:15 PM
  • Fix a PHP 8.1 check in local disk storage engine code.
Harbormaster completed remote builds in B25620: Diff 51834.Dec 16 2021, 11:16 PM
Harbormaster completed remote builds in B25621: Diff 51835.
epriestley updated this revision to Diff 51836.Dec 16 2021, 11:17 PM
  • Fix a PHP 8.1 issue in application search code.
Harbormaster completed remote builds in B25622: Diff 51836.Dec 16 2021, 11:18 PM
epriestley updated this revision to Diff 51837.Dec 16 2021, 11:21 PM
  • Fix another random PHP 8.1 issue.
Harbormaster completed remote builds in B25623: Diff 51837.Dec 16 2021, 11:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 11:24 PM
Closed by commit rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP6136964093cb: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.

Revision Contents
Changeset List

PathSize
3 lines
scripts/
sql/
2 lines
src/
applications/
people/
query/
2 lines
storage/
3 lines
phid/
handle/
pool/
10 lines
infrastructure/
cluster/
1 line
query/
2 lines
storage/
connection/
mysql/
7 lines
lisk/
104 lines

Diff 51834

View Options

.arclint

Loading...
View Options

scripts/sql/manage_storage.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/applications/phid/handle/pool/PhabricatorHandleList.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Loading...
View Options

src/infrastructure/query/PhabricatorQuery.php

Loading...
View Options

src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAO.php

Loading...
Phabricator · Built by Phacility