Page MenuHomePhabricator

Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
ClosedPublic

Authored by epriestley on Dec 16 2021, 11:07 PM.
Tags
None
Referenced Files
F18213008: D21744.id51834.diff
Tue, Aug 19, 3:49 AM
F18187844: D21744.id51837.diff
Sat, Aug 16, 8:19 PM
F18179342: D21744.id51838.diff
Sat, Aug 16, 3:30 AM
F18165024: D21744.id51831.diff
Fri, Aug 15, 7:35 AM
F18162157: D21744.id51833.diff
Fri, Aug 15, 4:13 AM
F18111012: D21744.id51835.diff
Tue, Aug 12, 4:50 AM
F18106621: D21744.id.diff
Sun, Aug 10, 11:10 PM
F18105865: D21744.id.diff
Sun, Aug 10, 8:06 PM
Subscribers
None

Details

Summary

Ref T13588. This configuration value may not be set.

Also fix an issue in bin/storage and whatever else I hit between now and this diff actually uploading.

Also fix a MySQLi report mode difference, beginning in PHP 8.1.

Also update a bunch of "static" property usage in Lisk.

Test Plan

Ran bin/files ... locally under PHP 8.1.

Diff Detail

Repository
rP Phabricator
Branch
php81
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25620
Build 35443: Run Core Tests
Build 35442: arc lint + arc unit

Unit TestsFailed

TimeTest
62 msPhabricatorHandlePoolTestCase::testHandlePools
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php(29): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 29) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/files/engine/PhabricatorFileStorageEngine.php(264): PhabricatorLocalDiskFileStorageEngine->canWriteFiles()
0 msAlmanacNamesTestCase::testServiceOrDeviceNames
30 assertions passed.
0 msAlmanacServiceTypeTestCase::testGetAllServiceTypes
1 assertion passed.
0 msAphrontHTTPHeaderParserTestCase::testHeaderParser
18 assertions passed.
0 msAphrontHTTPSinkTestCase::testHTTPHeaderNames
2 assertions passed.
View Full Test Results (1 Failed · 454 Passed · 2 Skipped)

Event Timeline

  • Add annotations for interfaces implemented by PhabricatorHandleList.
  • Fix a strlen() in query construction.
  • Correct behavior in query clause construction.
  • Fix a piece of user initializing code for PHP 8.1.
  • Fix a PHP 8.1 issue in user querying.
  • Fix a PHP 8.1 check in local disk storage engine code.
  • Fix a PHP 8.1 issue in application search code.
  • Fix another random PHP 8.1 issue.
This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 11:24 PM
This revision was automatically updated to reflect the committed changes.