Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 4:01 PM
Unknown Object (File)
Tue, Jan 21, 3:25 PM
Unknown Object (File)
Tue, Jan 21, 12:29 PM
Unknown Object (File)
Fri, Jan 17, 10:52 PM
Unknown Object (File)
Dec 23 2024, 12:30 AM
Unknown Object (File)
Dec 12 2024, 2:53 AM
Unknown Object (File)
Dec 6 2024, 10:50 PM
Unknown Object (File)
Dec 6 2024, 7:50 PM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Branch
php81
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25599
Build 35409: Run Core Tests
Build 35408: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.