Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
F18787697: D21740.diff
Wed, Oct 15, 1:01 AM
F18636709: D21740.id.diff
Wed, Sep 17, 4:57 AM
F18629273: D21740.id51812.diff
Tue, Sep 16, 8:23 AM
F18628825: D21740.diff
Tue, Sep 16, 7:22 AM
F18616226: D21740.id51812.diff
Sep 14 2025, 4:39 PM
F18609781: D21740.id51812.diff
Sep 14 2025, 3:52 AM
F18228909: D21740.diff
Aug 20 2025, 8:59 AM
F18224574: D21740.id51812.diff
Aug 20 2025, 12:11 AM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.