Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
F15399050: D21740.diff
Mon, Mar 17, 2:36 AM
F15398058: D21740.id51811.diff
Sun, Mar 16, 11:13 PM
F15392341: D21740.diff
Sat, Mar 15, 2:39 PM
F15381980: D21740.id51812.diff
Fri, Mar 14, 10:12 AM
F15315896: D21740.id51812.diff
Thu, Mar 6, 6:14 PM
Unknown Object (File)
Wed, Feb 26, 9:27 AM
Unknown Object (File)
Sat, Feb 22, 5:07 PM
Unknown Object (File)
Wed, Feb 19, 1:45 PM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Branch
php81
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25599
Build 35409: Run Core Tests
Build 35408: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.