Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
F12804697: D21740.diff
Wed, Mar 27, 4:34 PM
Unknown Object (File)
Sun, Mar 17, 12:20 PM
Unknown Object (File)
Sun, Mar 17, 12:20 PM
Unknown Object (File)
Sun, Mar 17, 12:12 PM
Unknown Object (File)
Sun, Mar 17, 11:28 AM
Unknown Object (File)
Feb 15 2024, 5:37 PM
Unknown Object (File)
Feb 4 2024, 1:28 AM
Unknown Object (File)
Jan 20 2024, 5:07 PM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Branch
php81
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25599
Build 35409: Run Core Tests
Build 35408: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.