Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
F18106614: D21740.id.diff
Sun, Aug 10, 11:10 PM
F18088776: D21740.id51811.diff
Wed, Aug 6, 9:23 AM
F18079764: D21740.id51812.diff
Mon, Aug 4, 9:24 PM
F17858517: D21740.id.diff
Sun, Jul 27, 7:42 PM
F17837992: D21740.diff
Sat, Jul 26, 6:03 PM
Unknown Object (File)
Jun 7 2025, 2:21 AM
Unknown Object (File)
May 26 2025, 7:34 AM
Unknown Object (File)
May 10 2025, 6:56 AM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Branch
php81
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25599
Build 35409: Run Core Tests
Build 35408: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.